This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Open
Conversation
Fix tm regex for XML comment <%-- --%>. The end rule key and the name key are in the scope of the captures key, but should be up one level in the comments patterns.
The grammar file for xml in VS is
"comments": {
"patterns": [
{
"begin": "<%--",
"captures": {
"0": {
"name": "punctuation.definition.comment.xml"
},
"end": "--%>",
"name": "comment.block.xml"
}
but should be:
"comments": {
"patterns": [
{
"begin": "<%--",
"captures": {
"0": {
"name": "punctuation.definition.comment.xml"
}
},
"end": "--%>",
"name": "comment.block.xml"
},
Repro:
Add the <%-- style comment patterns to a XML file.
<%--
This comment and all following content is not syntax colored.
--%>
All following lines are not processed for syntax coloring because the end rule key is missing for the comments patterns.
Test:
With the fixed regex, the comment will be correctly syntax colored as well as all the following xml content.
Author
This was referenced Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fix tm regex for XML comment <%-- --%>. The end rule key and the name key are in the scope of the captures key, but should be up one level in the comments patterns.
The grammar file for xml in VS is
but should be:
Repro:
Add the <%-- style comment patterns to a XML file.
<%--
This comment and all following content is not syntax colored.
--%>
All following lines are not processed for syntax coloring because the end rule key is missing for the comments patterns.
Test:
With the fixed regex, the comment will be correctly syntax colored as well as all the following xml content.
Requirements
Alternate Designs
Benefits
Possible Drawbacks
Applicable Issues